random fixes that help vite/sveltekit #3140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ |
|
❌ @paperdave 2 files with test failures on linux-x64-baseline:
|
|
❌ @paperdave 2 files with test failures on linux-x64:
|
|
❌ @paperdave 4 files with test failures on bun-darwin-x64-baseline:
|
paperdave
force-pushed
the
dave/random-fixes
branch
from
78e60da
to
77374ee
Compare
| @@ -1129,6 +1129,41 @@ pub const Resolver = struct { | |||
| return .{ .not_found = {} }; | |||
| } | |||
|
|
|||
| if (strings.hasPrefixComptime(import_path, "file:///")) { | |||
There was a problem hiding this comment.
This doesn't handle space characters or anything percent-encoded
but it is better than status quo
| return Exists{ | ||
| .path = path, | ||
| .path = PathLike.fromJS(ctx, arguments, exception), |
There was a problem hiding this comment.
I don't like this fix, it should be handled earlier in the function instead of these extra null checks.
But it does fix the issue. Please add a TODO note to address this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status — hello worlds work, but real applications including the sveltekit demo do not fully work
This PR makes progress towards #250 and #600, fixing small random bugs in places to help vite and sveltekit run within bun's runtime:
existsSync(null)and other invalid paths must not throwimport "file:///..."Path.isAbsoluteStringsupports utf16 stringsBun.readableStreamToArrayBuffersync if possible.this also (temporarily) contains changes from #2913 which I think help out vite